Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary RPC stubs for get_difficulty and get_block fields #6067

Closed
wants to merge 18 commits into from

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Feb 1, 2023

Motivation

This PR contains some RPC stubs or implementations that can be used until we implement these RPCs properly and merge them to main.

@teor2345 teor2345 added the do-not-merge Tells Mergify not to merge this PR label Feb 1, 2023
@teor2345 teor2345 self-assigned this Feb 1, 2023
@github-actions github-actions bot added the C-feature Category: New features label Feb 1, 2023
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #6067 (106bd98) into main (0aab3df) will increase coverage by 0.11%.
The diff coverage is 85.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6067      +/-   ##
==========================================
+ Coverage   77.94%   78.05%   +0.11%     
==========================================
  Files         304      304              
  Lines       39035    39126      +91     
==========================================
+ Hits        30425    30540     +115     
+ Misses       8610     8586      -24     

@teor2345 teor2345 changed the base branch from main to rpc-incorrect-params February 1, 2023 04:58
@teor2345 teor2345 changed the title Testing: RPC stubs for get_difficulty and validate_address Testing only: RPC stubs for get_difficulty and validate_address Feb 1, 2023
@teor2345 teor2345 removed the C-feature Category: New features label Feb 1, 2023
@teor2345 teor2345 changed the title Testing only: RPC stubs for get_difficulty and validate_address Temporary RPC stubs for get_difficulty and validate_address Feb 1, 2023
Base automatically changed from rpc-incorrect-params to main February 1, 2023 18:20
@github-actions github-actions bot added the C-feature Category: New features label Feb 2, 2023
@teor2345 teor2345 changed the title Temporary RPC stubs for get_difficulty and validate_address Temporary RPC stubs for get_difficulty and get_block fields Feb 3, 2023
@teor2345
Copy link
Contributor Author

teor2345 commented Feb 7, 2023

All the essential parts of this PR will be in the main branch after #6097 merges (it's currently in the queue).

@teor2345 teor2345 closed this Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: New features do-not-merge Tells Mergify not to merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants