Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(net): Drop Firo cryptocurrency nodes from Zebra's address book, because they are not compatible with Zcash" #6477

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

teor2345
Copy link
Contributor

Motivation

This bug with Firo was diagnosed incorrectly. The issue is actually with the Flux/ZelCash network, which is already excluded by Zebra.

Reverts #6398

@teor2345 teor2345 added C-bug Category: This is a bug P-Low ❄️ A-network Area: Network protocol updates or fixes A-compatibility Area: Compatibility with other nodes or wallets, or standard rules labels Apr 10, 2023
@teor2345 teor2345 requested a review from a team as a code owner April 10, 2023 21:39
@teor2345 teor2345 self-assigned this Apr 10, 2023
@teor2345 teor2345 requested review from upbqdn and removed request for a team April 10, 2023 21:39
@github-actions github-actions bot added the C-feature Category: New features label Apr 10, 2023
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #6477 (64b9c1a) into main (044ecb0) will decrease coverage by 0.21%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6477      +/-   ##
==========================================
- Coverage   77.89%   77.69%   -0.21%     
==========================================
  Files         304      304              
  Lines       39678    39678              
==========================================
- Hits        30908    30827      -81     
- Misses       8770     8851      +81     

mergify bot added a commit that referenced this pull request Apr 11, 2023
@mergify mergify bot merged commit 3d11a09 into main Apr 11, 2023
@mergify mergify bot deleted the revert-6398-ignore-firo-nodes branch April 11, 2023 17:21
@arya2 arya2 mentioned this pull request Apr 18, 2023
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compatibility Area: Compatibility with other nodes or wallets, or standard rules A-network Area: Network protocol updates or fixes C-bug Category: This is a bug C-feature Category: New features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants