-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(utils): Add a direct connection mode to zebra-checkpoints #6516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
A-rust
Area: Updates to Rust code
C-enhancement
Category: This is an improvement
P-Medium ⚡
A-rpc
Area: Remote Procedure Call interfaces
A-compatibility
Area: Compatibility with other nodes or wallets, or standard rules
labels
Apr 14, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6516 +/- ##
==========================================
+ Coverage 77.72% 78.03% +0.30%
==========================================
Files 307 307
Lines 40282 40256 -26
==========================================
+ Hits 31310 31414 +104
+ Misses 8972 8842 -130 |
teor2345
force-pushed
the
checkpoints-direct-rpc
branch
from
April 19, 2023 22:16
ba63bac
to
d78be65
Compare
teor2345
force-pushed
the
checkpoints-direct-rpc
branch
from
April 21, 2023 00:03
d78be65
to
75f342f
Compare
teor2345
force-pushed
the
checkpoints-direct-rpc
branch
from
April 23, 2023 21:53
75f342f
to
838a98d
Compare
7 tasks
upbqdn
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I left a couple of minor suggestions and questions.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-compatibility
Area: Compatibility with other nodes or wallets, or standard rules
A-rpc
Area: Remote Procedure Call interfaces
A-rust
Area: Updates to Rust code
C-enhancement
Category: This is an improvement
C-feature
Category: New features
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
Test the new direct JSON-RPC connections using:
And the refactored existing functionality using:
Motivation
In #6367 we want to generate checkpoints in CI. This is the Rust tool part of that ticket.
Complex Code or Requirements
There are 4 modes in this tool now:
This means we need to test all of them. (Which I've done.)
Technically this code is async, but it doesn't actually use much concurrency.
Solution
Related Changes:
zebra-checkpoints
implementationTryIntoHeight
convenience trait for converting integers, strings, and JSON to valid heights (we'll use this in other fixes like [NCC-E005955-XVE]zebra-chain
: Inconsistent error management inAdd
andSub
forHeight
#6279)Unrelated cleanups:
Testing
The rest of the testing will happen as part of the next PR which puts this in CI.
Review
This is part of a routine release process simplification change.
Reviewer Checklist
Follow Up Work
Add this new tool to CI, so we always have checkpoints ready for releases.
Fully test the generated checkpoints.