fix(net): Reject nodes using ZClassic ports, and warn if configured with those ports

[teor2345]

Motivation

We want to reject ZClassic nodes by port, because some block explorers are picking them up and sharing their addresses:
zcash/zcash#6505 (comment)

Zebra currently rejects ZClassic nodes because their protocol versions are too low, but we need to make a connection to do that. ZClassic could also increase their protocol versions in future.

We also want to warn the user if they configure their node with those ports.

Solution

• Add the ZClassic ports to our existing node port check
• Do the regtest and coin checks even if we don't have a network
• Replace our Mainnet/Tesnet wrong port check with the check we do on remote node addresses, including ports used by other coins

Review

This is a low priority peer handling and config issue.

Reviewer Checklist

• Will the PR name make sense to users?
  • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
• Are the PR labels correct?
• Does the code do what the ticket and PR says?
  • Does it change concurrent code, unsafe code, or consensus rules?
• How do you know it works? Does it have tests?

[codecov]

Codecov Report

Merging #6567 (31bf87b) into main (1461c91) will increase coverage by 0.15%.
The diff coverage is 58.82%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6567      +/-   ##
==========================================
+ Coverage   77.78%   77.93%   +0.15%     
==========================================
  Files         307      307              
  Lines       40273    40278       +5     
==========================================
+ Hits        31325    31390      +65     
+ Misses       8948     8888      -60     

[teor2345]

@Mergifyio update

[mergify]

update

✅ Branch has been successfully updated