-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): Delete mainnet and testnet disks separately #6582
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-bug
Category: This is a bug
A-devops
Area: Pipelines, CI/CD and Dockerfiles
P-High 🔥
I-integration-fail
Continuous integration fails, including build and test failures
labels
Apr 27, 2023
6 tasks
github-actions
bot
added
the
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
label
Apr 27, 2023
dconnolly
reviewed
Apr 27, 2023
dconnolly
reviewed
Apr 27, 2023
dconnolly
reviewed
Apr 27, 2023
dconnolly
reviewed
Apr 27, 2023
dconnolly
reviewed
Apr 27, 2023
dconnolly
reviewed
Apr 27, 2023
Co-authored-by: Deirdre Connolly <[email protected]>
Anyone can re-approve this PR, Deirdre has already reviewed it. |
gustavovalverde
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-devops
Area: Pipelines, CI/CD and Dockerfiles
C-bug
Category: This is a bug
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
I-cost
Zebra infrastructure costs
I-integration-fail
Continuous integration fails, including build and test failures
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In PR #6581, I started creating testnet cached state disks.
But the current disk cleanup job will treat them like mainnet disks, causing CI bugs like:
This is part of #6367.
To avoid these bugs, I temporarily disabled the disk deletion workflow in GitHub Actions.
Solution
Delete the mainnet and testnet disks separately, so each network always keeps a few disks.
Review
This is an urgent fix because it could stop all PRs merging for 3 days.
Here's a manual run of this workflow from this branch, after PR #6581 generated some testnet disks:
https://github.com/ZcashFoundation/zebra/actions/runs/4824829115
Reviewer Checklist
Follow Up Work
Re-enable disk deletion by turning this action back on:
https://github.com/ZcashFoundation/zebra/actions/workflows/delete-gcp-resources.yml