Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump indexmap, toml and serde_json #7100

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

oxarbitrage
Copy link
Contributor

Motivation

Dependabot opened pull requests for all these but they depend one of another for duplicated dependencies.

This pull request do all in the same PR.

Close #7067
Close #7068
Close #7069

I will close those pull requests in favour of this one if the CI pass. Will make additional changes to deny.toml if needed here.

Solution

Bump dependencies together.

Review

This is a draft until CI checks, anyone can review after that.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Jun 28, 2023
@oxarbitrage oxarbitrage marked this pull request as ready for review June 28, 2023 23:49
@oxarbitrage oxarbitrage requested review from a team as code owners June 28, 2023 23:49
@oxarbitrage oxarbitrage requested review from arya2 and removed request for a team June 28, 2023 23:49
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #7100 (982f8b1) into main (6ab451c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7100   +/-   ##
=======================================
  Coverage   77.27%   77.27%           
=======================================
  Files         310      310           
  Lines       41795    41795           
=======================================
  Hits        32297    32297           
  Misses       9498     9498           

@teor2345 teor2345 removed the request for review from a team June 29, 2023 06:54
mergify bot added a commit that referenced this pull request Jun 29, 2023
@mergify mergify bot merged commit 455779c into main Jun 29, 2023
@mergify mergify bot deleted the bump-toml-indexmap-serdejson branch June 29, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants