ref(docker): remove all unrequired docker arguments from CI/CD pipelines

[gustavovalverde]

Motivation

This is a follow-up work based on:

• ref(docker): organize ENV and ARG values based on their usage #7200

Considering we refactor all the ARGs and ENVs from the Dockerfile, we had a pending task of syncing those changes with the pipelines.

Complex Code or Requirements

Some inputs were being used for build arguments which are no longer required, in most scenarios those were using the same defaults we have on our Dockerfile, and thus were removed to reduce confusion for other engineers which might see those as a requirement.

The NETWORK has been removed from most inputs, and instead moved to the place where it should be: Docker environment variables (ENV) at runtime. Based on our entrypoint approach, this is safer.

Solution

• Remove build arguments which are not required from the calling action and the image build workflow
• Remove environment variables if those are build arguments, like SHORT_SHA (which is still part of the VM name)
• Prefer using -e (Docker ENV) instead of inputs or build arguments for $NETWORK

Review

Anyone from DevOps, but it might be easier for @upbqdn or Teor, as they participated in the previous review.

Reviewer Checklist

• Will the PR name make sense to users?
  • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
• Are the PR labels correct?
• Does the code do what the ticket and PR says?
  • Does it change concurrent code, unsafe code, or consensus rules?
• How do you know it works? Does it have tests?

Follow Up Work

None

[upbqdn]

utACK

[gustavovalverde]

This will need re-approval @upbqdn

[gustavovalverde]

@upbqdn sorry to ping you again for re-approval. I had to fix a typo as a tests was failing.