-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(panic): Log a warning instead of panicking for unused mining configs #7290
Conversation
@arya2 do you need someone to finish this work ? I can find some time to bump it up if you want. |
Yes, please. |
If we make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's get it merged before any more RPC work.
I committed a quick tweak to the mining config argument passing, because we don't need to pass ()
now the confit is always enabled.
Motivation
This PR will log a warning if there is a non-default mining section in the loaded config when compiled without the "getblocktemplate-rpcs" feature, instead of panicking.
Part of #7118.
Solution
config/mining.rs
Review
Anyone can review.
Reviewer Checklist