Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove(cmd): Remove zebrad download command, because it no longer does anything #7819

Merged
merged 6 commits into from
Oct 25, 2023
Merged

remove(cmd): Remove zebrad download command, because it no longer does anything #7819

merged 6 commits into from
Oct 25, 2023

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Oct 25, 2023 •
edited by upbqdn
Loading

Motivation

Now the parameters are built into the binary, we can remove the zebrad download command and the Dockerfiles and CI workflows that use it.

This significantly reduces the size of Docker images, by about 600 MB.

Close #7811

Solution

  • Remove zebrad download
  • Remove zcash-params/Dockerfile
  • Remove the CI workflow that builds the zcash-params Docker image
  • Update CHANGELOG for zebrad download removal

Review

This is a user-visible cleanup, let's merge it before the release next week, because the parameter change is already merged.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added A-rust Area: Updates to Rust code P-Medium ⚡ C-removal Category: Features that have been removed labels Oct 25, 2023
@teor2345 teor2345 self-assigned this Oct 25, 2023
@teor2345 teor2345 requested review from a team as code owners October 25, 2023 03:01
@teor2345 teor2345 requested review from upbqdn and removed request for a team October 25, 2023 03:01
@github-actions github-actions bot added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge labels Oct 25, 2023
@teor2345 teor2345 removed the extra-reviews This PR needs at least 2 reviews to merge label Oct 25, 2023
@github-actions github-actions bot added the extra-reviews This PR needs at least 2 reviews to merge label Oct 25, 2023
@teor2345 teor2345 added A-cli Area: Command-line interfaces and processes A-devops Area: Pipelines, CI/CD and Dockerfiles and removed C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge A-rust Area: Updates to Rust code labels Oct 25, 2023
upbqdn
upbqdn previously approved these changes Oct 25, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge labels Oct 25, 2023
@teor2345
Copy link
Contributor Author

Failed due to #7796

@teor2345 teor2345 mentioned this pull request Oct 25, 2023
Closed
6 tasks
@teor2345
Copy link
Contributor Author

I have disabled the coverage job and branch protection rule due to #7828, its failure will disappear the next time this PR's branch is updated.

@teor2345
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023

refresh

✅ Pull request refreshed

@teor2345 teor2345 removed C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge labels Oct 25, 2023
mergify bot added a commit that referenced this pull request Oct 25, 2023
@mergify
Merge of #7819
f233f9b
@mergify mergify bot mentioned this pull request Oct 25, 2023
Closed
@mergify mergify bot merged commit 71a9865 into main Oct 25, 2023
@mergify mergify bot deleted the rm-download-cmd branch October 25, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upbqdn upbqdn upbqdn approved these changes

Assignees

@teor2345 teor2345

Labels
A-cli Area: Command-line interfaces and processes A-devops Area: Pipelines, CI/CD and Dockerfiles C-removal Category: Features that have been removed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the zebrad download command
2 participants
@teor2345 @upbqdn