Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add progress markers to the snapshot tests #8106

Merged
merged 2 commits into from
Dec 14, 2023
Merged

test: Add progress markers to the snapshot tests #8106

merged 2 commits into from
Dec 14, 2023

Conversation

teor2345
Copy link
Contributor

Motivation

This test updates the snapshot tests with the newly added progress markers from PR #8080.

It also simplifies some related scanner code.

Close #8069

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

  • Write progress markers in the snapshot tests
  • Simplify the latest height method
  • Make marker writing more robust to future changes

Testing

This is expanding test coverage.

Review

This is a routine change.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@teor2345 teor2345 added P-Medium ⚡ C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG A-blockchain-scanner Area: Blockchain scanner of shielded transactions labels Dec 13, 2023
@teor2345 teor2345 self-assigned this Dec 13, 2023
@teor2345 teor2345 requested a review from a team as a code owner December 13, 2023 21:13
@teor2345 teor2345 requested review from arya2 and removed request for a team December 13, 2023 21:13
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

mergify bot added a commit that referenced this pull request Dec 14, 2023
@mergify mergify bot merged commit a14cb40 into main Dec 14, 2023
122 checks passed
@mergify mergify bot deleted the prog-snap branch December 14, 2023 21:32
@oxarbitrage oxarbitrage mentioned this pull request Jan 17, 2024
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: Add database snapshot tests for the scanner database
2 participants