Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix creating GCP instances #8301

Closed
wants to merge 2 commits into from
Closed

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Feb 20, 2024

Motivation

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

Solution

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

Refactor the cached disk selection. TODO: Replace the previous sentence with an issue number.

@upbqdn upbqdn added A-devops Area: Pipelines, CI/CD and Dockerfiles C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Critical 🚑 labels Feb 20, 2024
@upbqdn upbqdn self-assigned this Feb 20, 2024
@upbqdn upbqdn requested a review from a team as a code owner February 20, 2024 22:41
@upbqdn upbqdn requested review from gustavovalverde and removed request for a team February 20, 2024 22:41
@upbqdn
Copy link
Member Author

upbqdn commented Feb 20, 2024

Removing the variable effectively turns off using cached disks, but I don't think that worked before because we had a syntactic error in the --create-disk flag. We were missing a comma, which was added in 516fe1c (#8005). Adding the comma likely started causing the current issue since the --create-disk flag now evaluates to --create-disk=,, which seems to be the bug. Without the comma, DISK_OPTION evaluated to an empty string, and the name property directly followed, so the --create-disk flag was syntactically correct, but the image=$CACHED_DISK_NAME propery, set in DISK_OPTION, was missing.

Edit: the above is not quite right. I opened #8302.

@upbqdn upbqdn closed this Feb 21, 2024
@upbqdn upbqdn deleted the fix-creating-gcp-instances branch February 21, 2024 01:12
@upbqdn upbqdn removed the request for review from gustavovalverde February 21, 2024 01:14
@upbqdn
Copy link
Member Author

upbqdn commented Feb 21, 2024

This PR didn't address the underlying issue, so I'm closing it. We should address #8302 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Critical 🚑
Projects
None yet
Development

Successfully merging this pull request may close these issues.

main branch CI failed: push in Integration Tests on GCP
1 participant