Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-compose.yml - tiny typo #8893

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

skyl
Copy link
Contributor

@skyl skyl commented Sep 25, 2024

Motivation

Improve some of the getting started stuff ... play with running zebrad / lightwalletd stack with docker; maybe improve the documentation as I go if I find anything confusing.

Specifications & References

Solution

Tests

Follow-up Work

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@skyl
Copy link
Contributor Author

skyl commented Sep 25, 2024

WARN[0000] zebra/docker/docker-compose.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion 
WARN[0000] config `uid`, `gid` and `mode` are not supported, they will be ignored 

@oxarbitrage oxarbitrage marked this pull request as ready for review October 7, 2024 21:49
@oxarbitrage oxarbitrage requested a review from a team as a code owner October 7, 2024 21:49
@oxarbitrage oxarbitrage requested review from oxarbitrage and removed request for a team October 7, 2024 21:49
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this in as it is so the fix is present in the next release, @skyl please feel free to open additional pull requests. thanks!

mergify bot added a commit that referenced this pull request Oct 7, 2024
@mergify mergify bot merged commit 3220520 into ZcashFoundation:main Oct 7, 2024
83 of 84 checks passed
@skyl skyl deleted the patch-1 branch October 8, 2024 03:32
@skyl
Copy link
Contributor Author

skyl commented Oct 8, 2024

Let's merge this in as it is so the fix is present in the next release, @skyl please feel free to open additional pull requests. thanks!

cool, thanks!

dmidem pushed a commit to QED-it/zebra that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants