Run cargo autoinherit
#9041
Merged
Run cargo autoinherit
#9041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C-trivial
|
The 2 failing tests are expected and unrelated. We can merge either #9030 or this one and close the other one. |
oxarbitrage
force-pushed
the
autoinherit
branch
from
f0c797c to
6b14627
Compare
oxarbitrage
added
A-compatibility
oxarbitrage
requested review from
arya2 and
upbqdn
and removed request for
a team
oxarbitrage
added
A-dependencies
zancas
approved these changes
Nov 20, 2024
|
FYI: We are going to wait for Mainnet activation which should be next Saturday 21 of November. So this should be merged probably next week. |
arya2
added
do-not-merge
oxarbitrage
force-pushed
the
autoinherit
branch
2 times, most recently
from
17be5a1 to
b97e5c6
Compare
oxarbitrage
force-pushed
the
autoinherit
branch
from
b97e5c6 to
3ca3993
Compare
|
This might be a good time to merge this so i updated the PR by executing |
Co-authored-by: zancas <[email protected]>
oxarbitrage
force-pushed
the
autoinherit
branch
from
3ca3993 to
c4e6dee
Compare
upbqdn
removed
the
C-trivial
conradoplg
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The CI seems to be stuck in #9030. This is just a temporal replacement that test the changes against the full suite.
It was done by running
cargo autoinheritlocally and pushing the results. It is the same code changes as #9030Solution
Tests
Follow-up Work
PR Author's Checklist
PR Reviewer's Checklist