Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Remove the release crates workflow #9120

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Jan 14, 2025

Motivation

Fix https://github.com/ZcashFoundation/zebra/actions/runs/12751834865/job/35539829251?pr=9114.

This PR is an exact copy of #9119, which targetted #9114. This PR targets main for better commit history.

Solution

  • Remove the workflow and its associated bash script.

Rationale

It didn't catch publishing issues in the past, and it skips a bunch of things anyway.

..., it wasn't doing much with --no-verify anyway.

It was working fine with the previous version of Rust. I think the latest stable version broke --no-verify, because it wasn't pulling dependencies from crates.io before (which is how we ended up with git sources on main when we were trying to publish Zebra), but now it does even if --no-verify is passed in explicitly.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@upbqdn upbqdn added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-High 🔥 labels Jan 14, 2025
@upbqdn upbqdn self-assigned this Jan 14, 2025
@upbqdn upbqdn requested review from a team as code owners January 14, 2025 19:40
@upbqdn upbqdn requested review from arya2 and removed request for a team January 14, 2025 19:40
@github-actions github-actions bot added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge labels Jan 14, 2025
@upbqdn upbqdn removed C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge labels Jan 14, 2025
@github-actions github-actions bot added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge labels Jan 14, 2025
@upbqdn
Copy link
Member Author

upbqdn commented Jan 14, 2025

More context: #9114 (comment).

mergify bot added a commit that referenced this pull request Jan 14, 2025
mergify bot added a commit that referenced this pull request Jan 15, 2025
@gustavovalverde gustavovalverde changed the title fix(CI): Remove the "release crates" workflow fix(ci): Remove the release crates workflow Jan 15, 2025
@gustavovalverde
Copy link
Member

@mergify refresh

Copy link
Contributor

mergify bot commented Jan 15, 2025

refresh

✅ Pull request refreshed

@gustavovalverde
Copy link
Member

@mergify dequeue

Copy link
Contributor

mergify bot commented Jan 15, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #9120 has been dequeued by a dequeue command

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Copy link
Contributor

mergify bot commented Jan 15, 2025

dequeue

✅ The pull request has been removed from the queue batched

@gustavovalverde
Copy link
Member

@mergify requeue

Copy link
Contributor

mergify bot commented Jan 15, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request Jan 15, 2025
@gustavovalverde
Copy link
Member

@mergify dequeue

Copy link
Contributor

mergify bot commented Jan 15, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #9120 has been dequeued by a dequeue command

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Copy link
Contributor

mergify bot commented Jan 15, 2025

dequeue

✅ The pull request has been removed from the queue batched

@gustavovalverde
Copy link
Member

Something odd happened with this PR as it's not triggering some tests (maybe deleting a workflow has a different behavior), I'll admin merge it in the meanwhile and track this to see if it happens in another PR.

@gustavovalverde gustavovalverde merged commit 050cdc3 into main Jan 15, 2025
95 of 97 checks passed
@gustavovalverde gustavovalverde deleted the remove-release-workflow branch January 15, 2025 12:02
@upbqdn
Copy link
Member Author

upbqdn commented Jan 15, 2025

The issue might be that this PR is an exact copy of #9119, which merged into #9114, which already merged into main. I forgot to explicitly prevent #9114 from merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge P-High 🔥
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants