This repository has been archived by the owner on Jan 21, 2022. It is now read-only.
Implemented Utf-8 conversions for strings from and to the library. #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmfrederik
reviewed
Sep 20, 2017
| /// </summary> | ||
| /// <param name="ptr">The c-style string pointer</param> | ||
| /// <returns>The string object</returns> | ||
| public static string Utf8InteropToString(IntPtr ptr) |
There was a problem hiding this comment.
On newer versions of .NET (netstandard2) you can use Marshal.PtrToStringUTF8
qmfrederik
reviewed
Sep 20, 2017
| return true; | ||
| } | ||
|
|
||
| /// <summary>En cas de substitution dans une classe dérivée, obtient une valeur indiquant si la valeur du handle n'est pas valide.</summary> |
There was a problem hiding this comment.
Should just be "Obtient une valeur indiquant si la valeur du handle n'est pas valide" (having fun, sorry)
There was a problem hiding this comment.
Oops, I left a french comment as generated by my VS, sorry :D
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #305