This repository has been archived by the owner on Jan 21, 2022. It is now read-only.
[RFC]Exposed Core.VlcMediaPlayer and Interops.VlcManager #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you have a use for it and other people do too apparently, I don't see why it should not be exposed. That being said, maybe add some ALL CAPS WARNING USE AT YOUR OWN RISK! or something in the comments, so the caller knows what he/she's getting into? |
|
I do have a warning, but not all caps, should I change that? |
|
I would, that way they know you mean business. But the important part is that there is a warning 👍 |
jeremyVignelles
force-pushed
the
feature/internals-exposure
branch
from
dd3d7af to
54ea3f2
Compare
added 2 commits
October 5, 2017 12:10
It allows users to unlock features that are not yet implemented/too low-level to be implemented in the VlcControl.
jeremyVignelles
force-pushed
the
feature/internals-exposure
branch
from
54ea3f2 to
a9ad545
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows users to unlock features that are not yet implemented/too low-level to be implemented in the VlcControl.
What do you think about this? Is it too dangerous to let users play with the internals of this library?
Fixes #239