This repository has been archived by the owner on Jan 21, 2022. It is now read-only.
Strongly type UTf8 strings using SafeHandle #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in a strongly typed fashion rather than DangerousGetHandle() The CLR will marshal a SafeHandle to and from IntPtr automatically which makes the delegates strongly typed, you can only pass in a Utf8StringHandle which is created through Utf8InteropStringConverter
jeremyVignelles
approved these changes
Oct 26, 2017
|
If https://apisof.net/catalog/System.Runtime.InteropServices.ICustomMarshaler Something like https://github.com/nikki-nn4/NimDemo/blob/e87abf020f26e6bc98c9d0ea4faf0cdc0cd0660e/Assets/nim/Utility/UTF8StringMarshaler.cs would probably work nicely. The signatures would be long, greatly simplified usage again. Just a passing comment. |
|
Thanks, You can check in 2.2.2-develop225 :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
SafeUnmanagedMemoryHandletoUtf8StringHandle- it's now used in a strongly typed fashion rather thanDangerousGetHandle()The
CLRwill marshal aSafeHandleto and fromIntPtrautomatically which makes the delegates strongly typed, you can only pass in a Utf8StringHandle which is created through Utf8InteropStringConverter. Should make the API more readable.All the
InteropObjectInstanceclasses could be removed and the delegates could be changed to useSafeHandles, make the code more readable/maintainable in my opinion.Let me know what you think.