Bug fix/propagate float to long

[zandiarash]

According to this thread I've changed float types to long for

e.NewLength;

private void OnVlcMediaLengthChanged(object sender, VlcMediaPlayerLengthChangedEventArgs e)
        {
           e.NewLength;
        }

and I've tested the project.

[jeremyVignelles]

Nice, thanks.

Can you squash your commits into one an force-push in your branch please? Otherwise, I'll squash the commits when merging

[zandiarash]

Sir, that is my first pull request in the github so that I'm not familiar with and I am an amateur programmer.
I think I don't have the permission of squashing.

Only those with write access to this repository can merge pull requests.

how can I do that ? should I create a new pull request with another way ? or squash this existing pull request ?

[jeremyVignelles]

I was not referring to github, but to a git rebase to rewrite your commit history. It's a risky operation so that's better to know what you are doing.

Leave it like that, I will do that myself in a few days.

[zandiarash]

Does it mean that my pull request is Unusable with out squashing !?
pardon me...

[jeremyVignelles]

You pull request is nice and usable ( I still need to test though). I'm just nitpicking : I like having a clean git history and having a single commit to fix that, rather than 4 commits

[zandiarash]

I was also wondering to make a PR for PositionChanged too. but it seems that I should read more about github.
by the way thanks for your kindness to me.

[jeremyVignelles]

You're welcome, I welcome everyone wanting to make contributions to this project.

For LengthChanged? Isn't this what this PR is about?

Your PR is fine, don't worry. I was talking about advanced git usage I didn't know until recently.

[zandiarash]

sorry my mistake.
I mean PositionChanged which is float too.
I've editted last comment.

[jeremyVignelles]

PositionChanged must be a float as far as I know : it represents the proportion of the video that has been played (between 0 and 1)

[zandiarash]

Dear @jeremyVignelles special thanks for your assistance.

[jeremyVignelles]

This PR has been merged manually, thanks for your contribution! A new package will be available in a few minutes : 3.0.0-develop303

[zandiarash]

now can I delete the branch ?

[jeremyVignelles]

Yes, you can