Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(pizzaoven) settings for easy production-like integration testing environment #607

Merged
merged 47 commits into from
Apr 19, 2023
Merged

(pizzaoven) settings for easy production-like integration testing environment #607

merged 47 commits into from
Apr 19, 2023

Conversation

thesethtruth
Copy link
Collaborator

@thesethtruth thesethtruth commented Apr 12, 2023 •
edited by Erikvv
Loading

To do:

thesethtruth and others added 22 commits March 24, 2023 14:01
@thesethtruth
add dummy jsons
728e0c0
@thesethtruth
autocommit [migrate-all] for peter
41e1744
@thesethtruth
autocommit [migrate-all] for gillis
1172bcf
@thesethtruth
Merge branch 'latest-dm' of https://github.com/ZEnMo/Holon-webapp int…
b54bc1c 
…o latest-dm
@thesethtruth
autocommit [migrate-all] for jorrit
34170ab
@thesethtruth
clean up fixtures
3e4f1ac
@thesethtruth
fix jorrit fixture
e45495f
@thesethtruth
autocommit [migrate-all] for peter
d51b6bf
@thesethtruth
autocommit [migrate-all] for jorrit
664f2c4
@thesethtruth
autocommit [migrate-all] for gillis
0fe5df5
@mattijsstam
Merge pull request #518 from ZEnMo/main
5d25491 
merge main in latest dm
@thesethtruth
work on pizza
53bb0b9
@thesethtruth
add variable server_name in nginx
744d393
@thesethtruth
remove media and static volumes
3b662d8
@thesethtruth
remove old stuff
d3eead4
@thesethtruth
its a bake day
fcb88c5
@thesethtruth
somewhere there was an env var not set correctly, I don't know which …
3685d86 
…was the one but it works so you know, fine
@thesethtruth
remove more outdated
e4956ba
@thesethtruth
Merge branch 'main' into pizzaoven
64a5147
@thesethtruth
add a clean restart script
2afb99a
@thesethtruth
force cache
23da7ef
@thesethtruth
Merge branch 'main' into pizzaoven
2a52810
@thesethtruth thesethtruth requested a review from Erikvv April 12, 2023 11:35
Erikvv
Erikvv requested changes Apr 13, 2023
View reviewed changes
Copy link
Member

@Erikvv Erikvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S.v.p. alle bestanden eindigen met een newline. Dit kun je ook aanzetten in VS Code. Setting "Insert Final Newline"

docker-compose.yml Show resolved Hide resolved
docker-compose.prod.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@thesethtruth
Copy link
Collaborator Author

S.v.p. alle bestanden eindigen met een newline. Dit kun je ook aanzetten in VS Code. Setting "Insert Final Newline"

Waar kom je dit tegen? Ik denk dat het een artefact is van half op de remote omgeving fixes doen en dan niet alle settings van mijn lokale VS gebruiken.

@Erikvv
Copy link
Member

Erikvv commented Apr 18, 2023

Waar kom je dit tegen? Ik denk dat het een artefact is van half op de remote omgeving fixes doen en dan niet alle settings van mijn lokale VS gebruiken.

Is niet blocking wat mij betreft.

broekhuisg
broekhuisg approved these changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@broekhuisg broekhuisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functioneel lokaal getest en het draait. Verder zie ik geen bijzonderheden in de code.

@thesethtruth thesethtruth merged commit c6b975c into main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattijsstam mattijsstam mattijsstam left review comments

@broekhuisg broekhuisg broekhuisg approved these changes

@Erikvv Erikvv Erikvv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thesethtruth @Erikvv @mattijsstam @broekhuisg