158 show edit projects #196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cancel is not working
Save original data to cancel. still needs work
macano
had a problem deploying
to
swarm-pullrequest
GitHub Actions
Failure
macano
temporarily deployed
to
swarm-pullrequest
GitHub Actions
Inactive
Erikvv
reviewed
Dec 18, 2024
| } | ||
|
|
||
| // Update | ||
| put("/projects/{projectId}") { |
Erikvv
reviewed
Dec 18, 2024
| get("/projects") { | ||
| val userId = call.getUserId() | ||
| if (userId == null) { | ||
| if (userId == null) { // Check if it's admin to return all the projects |
Erikvv
reviewed
Dec 18, 2024
| val projectId = UUID.fromString(call.parameters["projectId"]) | ||
|
|
||
| val userId = call.getUserId() | ||
| if (userId == null) { // Check if the user have access to the project |
Erikvv
reviewed
Dec 18, 2024
| export async function getProjectById(projectId: string): Promise<Project | null> { | ||
| try { | ||
| return await ztorFetch(`/projects/${projectId}`); | ||
| } catch (error) { |
There was a problem hiding this comment.
I don't think we should catch these errors. Later we can make an error boundary in React to display it nicer.
Erikvv
reviewed
Dec 18, 2024
| } else { | ||
| setIsEditing(true); | ||
| } | ||
| }, [projectId]); |
There was a problem hiding this comment.
It's probably easier to put this in a route loader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.