ZEUS-2688: Receive: auto-enable route hints

[kaloudis]

Description

Relates to issue: ZEUS-2688

This pull request is categorized as a:

• New feature
• Bug fix
• Code refactor
• Configuration change
• Locales update
• Quality assurance
• Other

Checklist

• I’ve run yarn run tsc and made sure my code compiles correctly
• I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
• I’ve run yarn run prettier and made sure my code is formatted correctly
• I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

• No, I’m a fool
• Yes
• x ] N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

• Android
• iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

• Embedded LND
• LND (REST)
• LND (Lightning Node Connect)
• Core Lightning (CLNRest)
• LndHub
• [DEPRECATED] Core Lightning (c-lightning-REST)
• [DEPRECATED] Core Lightning (Spark)
• [DEPRECATED] Eclair

Locales

• I’ve added new locale text that requires translations
• I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

• Contributors will need to run yarn after this PR is merged in
• 3rd party dependencies have been modified:
  • verify that package.json and yarn.lock have been properly updated
  • verify that dependencies are installed for both iOS and Android platforms

Other:

• Changes were made that require an update to the README
• Changes were made that require an update to onboarding

[myxmaster]

we can break early when 1 announced channel was found

[myxmaster]

better use break; after haveAnnouncedChannels = true;

[kaloudis]

better use break; after haveAnnouncedChannels = true;

there are other enhancements occurring in this loop

[myxmaster]

ah of course

[myxmaster]

I think we should also enable "Include route hints" in Invoices settings in case there are no announced channels.

If later an announced channel is opened, the setting can stay enabled imo.

[kaloudis]

I think we should also enable "Include route hints" in Invoices settings in case there are no announced channels.

If later an announced channel is opened, the setting can stay enabled imo.

this already exists

[myxmaster]

this already exists

I was thinking about global settings, because it might be confusing to see that option being disabled but Zeus still enabling it when actually creating an invoice...
But now I'm not sure... With your approach, when user opens an announced channel later, then it will fall back to not include route hints by default, which might be better for privacy.

[myxmaster]

Ah I think we can stick with your approach and simply modify views.Receive.routeHintSwitchExplainer2.

Before:
It's helpful to toggle route hints on if you're using only unannounced channels, or if someone trying to pay you cannot reach you via your announced channels.

After:
Route hints are automatically enabled when you only have unannounced channels, ensuring payments can reach your node.

[myxmaster]

tested, lgtm