[FEATURE] Capture metrics #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Deepak <[email protected]>
Signed-off-by: Deepak <[email protected]>
Signed-off-by: Deepak <[email protected]>
Signed-off-by: Deepak <[email protected]>
chandrasekharan-zipstack
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
LGTM - here are few suggestions for later
- Try using a base interface to inherit / implement necessary metrics capturing attributes and functions. With the current logic it might not be easy to extend to other parts of the SDK in a robust fashion
- Usage reason /
self.__class__.__name__can be a part of this metrics dict returned by the mixin class
|
@Deepak-Kesavan can you also ensure that errors during the metrics collection are suppressed and logged as a warning to not prevent the user from accessing something? |
Signed-off-by: Deepak <[email protected]>
Signed-off-by: Deepak <[email protected]>
Signed-off-by: Deepak <[email protected]>
chandrasekharan-zipstack
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
LGTM overall. @Deepak-Kesavan you might want to catch any exceptions coming from the wrapper / MetricsMixin and log them as warnings to not block a user from executing something
Signed-off-by: Deepak <[email protected]>
Signed-off-by: Deepak <[email protected]>
gaya3-zipstack
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
MetricsMixinto capture time taken in each stepcapture_metricsdecorator functionWhy
How
...
Relevant Docs
Related Issues or PRs
Zipstack/unstract#900
Dependencies Versions / Env Variables
Notes on Testing
...
Screenshots
...
Checklist
I have read and understood the Contribution Guidelines.