fixed connection closing prematurely in index.py #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pk-zipstack
requested review from
chandrasekharan-zipstack,
gaya3-zipstack and
a team
|
|
Modifed the single try-except block into two enclosed by a parent try except block Signed-off-by: Praveen Kumar <[email protected]>
gaya3-zipstack
approved these changes
Jan 6, 2025
Signed-off-by: Praveen Kumar <[email protected]>
chandrasekharan-zipstack
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix for premature connection closure in vector database queries affecting Qdrant and Weaviate integrations.
Why
The vector database connection was being closed too early due to a misplaced
finallyblock, causing query attempts to fail with "Cannot send a request, as the client has been closed" errors. This was affecting prompt execution in both prompt studio.How
finallyblock that was closing the connection prematurelyfinallyblock at the end of the functionAll the above changes are made in index.py
Relevant Docs
Related Issues or PRs
Dependencies Versions / Env Variables
Notes on Testing
...
Screenshots
...
Checklist
I have read and understood the Contribution Guidelines.