-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link ExecutionLogs with FileExecutionEntity #1045
Link ExecutionLogs with FileExecutionEntity #1045
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. However since it involved migration, would like to have @hari-kuriakose's point of view.
@muhammad-ali-e Migration looks good. NOTE: Since null value seems to be allowed, I am assuming that's because there can be workflows without execution logs. |
|
Quality Gate passedIssues Measures |
What
WorkflowFileExecution
entity into theExecutionLogs
model to associate logs with specific file executions using theFileExecutionId/RunId
.Why
How
ExecutionLogs
andWorkflowFileExecution
models.FileExecutionId
inExecutionLogs
to track logs related to each file execution.Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
backend
andrunner(Worker)
Database Migrations
ExecutionLogs
andWorkflowFileExecution
.Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.