-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Health check API for backend & Prompt Sevice #1048
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chandrasekharan-zipstack 's comment on env seems a valid question. Will wait for that. Other than that, I do not see any concern in the PR.
Addressed the comment, @gaya3-zipstack |
Quality Gate passedIssues Measures |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
What
PR focus on health check API for prompt service & platform service.
...
Why
To support readiness and liveness probe for k8s deployment.
...
How
Exposing an endpoint, which is public retuning 200 OK.
...
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
No, this PR introduces new endpoints.
...
Database Migrations
Not applicable.
...
Env Config
Not applicable.
...
Relevant Docs
https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-a-liveness-http-request
...
Related Issues or PRs
Dependencies Versions
Not applicable.
...
Notes on Testing
Tested the API using rest client.
Created an deployment with sample deployment.yaml using minikube and checked the probes.
...
Screenshots
Checklist
I have read and understood the Contribution Guidelines.