Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] FS APIs for Line item extractor #1060

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

harini-venkataraman
Copy link
Contributor

What

FS APIs for line item feature
...

Why

To support k8s migration in cloud.
...

How

Usage of FS APIs from SDK.
...

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

No, the changes are under feature flag.
...

Database Migrations

Not applicable.
...

Env Config

Not applicable.
...

Relevant Docs

Not applicable.
...

Related Issues or PRs

Not applicable.
...

Dependencies Versions

Not applicable.
...

Notes on Testing

Would need @Deepak-Kesavan `s help for testing this new feature.

Checklist

I have read and understood the Contribution Guidelines.

Copy link
Contributor

@gaya3-zipstack gaya3-zipstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks fine. One minor improvisation added.

@gaya3-zipstack
Copy link
Contributor

PR looks fine. One minor improvisation added.

Added more comments.pls check

Copy link
Contributor

@gaya3-zipstack gaya3-zipstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Deepak-Kesavan Deepak-Kesavan merged commit e5e9d1e into feature/line-item-extraction Jan 10, 2025
4 checks passed
@Deepak-Kesavan Deepak-Kesavan deleted the feat/fs-api-line-item branch January 10, 2025 07:59
ritwik-g pushed a commit that referenced this pull request Jan 15, 2025
* Changes for line-item extraction prompt type

Signed-off-by: Deepak <[email protected]>

* Removed commented out code

Signed-off-by: Deepak <[email protected]>

* Minor fix

Signed-off-by: Deepak <[email protected]>

* Minor improvements

Signed-off-by: Deepak <[email protected]>

* [FEAT] FS APIs for Line item extractor (#1060)

* FS APIs for Line item extractor

* Optimizing if-else branch

* Minor fix

Signed-off-by: Deepak <[email protected]>

---------

Signed-off-by: Deepak <[email protected]>
Signed-off-by: Deepak K <[email protected]>
Co-authored-by: harini-venkataraman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants