-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] FS APIs for Line item extractor #1060
[FEAT] FS APIs for Line item extractor #1060
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks fine. One minor improvisation added.
Added more comments.pls check |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
* Changes for line-item extraction prompt type Signed-off-by: Deepak <[email protected]> * Removed commented out code Signed-off-by: Deepak <[email protected]> * Minor fix Signed-off-by: Deepak <[email protected]> * Minor improvements Signed-off-by: Deepak <[email protected]> * [FEAT] FS APIs for Line item extractor (#1060) * FS APIs for Line item extractor * Optimizing if-else branch * Minor fix Signed-off-by: Deepak <[email protected]> --------- Signed-off-by: Deepak <[email protected]> Signed-off-by: Deepak K <[email protected]> Co-authored-by: harini-venkataraman <[email protected]>
What
FS APIs for line item feature
...
Why
To support k8s migration in cloud.
...
How
Usage of FS APIs from SDK.
...
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
No, the changes are under feature flag.
...
Database Migrations
Not applicable.
...
Env Config
Not applicable.
...
Relevant Docs
Not applicable.
...
Related Issues or PRs
Not applicable.
...
Dependencies Versions
Not applicable.
...
Notes on Testing
Would need @Deepak-Kesavan `s help for testing this new feature.
Checklist
I have read and understood the Contribution Guidelines.