-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Fixing regression for remote storage file view #1063
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving it. @harini-venkataraman I hope we have a test on local
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specific changes for adoption of new API response type looks fine.
|
Quality Gate passedIssues Measures |
What
PR to fix regression in remote storage for file view.
...
Why
The raw view, summary view and PDF view is broken because of changes API contract.
...
How
Fixed by adding the response changes in corresponding methods.
...
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
No, the changes are under feature flag.
...
Database Migrations
Not applicable.
..
Env Config
Not applicable.
..
Relevant Docs
Not applicable.
..
Related Issues or PRs
Version - 0.104.2
Dependencies Versions
Not applicable.
..
Notes on Testing
Tested the file indexing and viewing Pdf.
...
Screenshots
Checklist
I have read and understood the Contribution Guidelines.