-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Replace 'markdown-to-jsx' with 'remarkable' for Better Large Markdown String Support #903
Conversation
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@tahierhussain Hope all the imports of the previous used library is removed/replaced, if any.
Yes, @athul-rs. The previous library has been removed. The previous library was only used inside the |
What
This PR replaces the
markdown-to-jsx
library with theremarkable
library for rendering Markdown content in the application.Why
markdown-to-jsx
library struggles with very large Markdown strings, leading to performance issues and even crashes in some cases.remarkable
library is chosen as a replacement because:How
Replaced
markdown-to-jsx
withremarkable
in the MarkdownRenderer component.Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
No. The changes are limited to the MarkdownRenderer component, which is used in only one place — inside the workflow. So, the chances of this PR breaking any existing features is very low.
Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
Screenshots
Large markdown text is rendered without any issues:
Checklist
I have read and understood the Contribution Guidelines.