Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.29.0 (take two) #1115

Closed
knight-of-ni opened this issue Oct 22, 2015 · 86 comments
Closed

Release v1.29.0 (take two) #1115

knight-of-ni opened this issue Oct 22, 2015 · 86 comments
Milestone

Comments

@knight-of-ni
Copy link
Member

Supersedes #549

This is my attempt to document what we need to complete before we release:

@knnniggett

@connortechnology

@pliablepixels

  • Confirm we've reached a good stopping point for development of the API
  • Keep all his cool new ideas to himself until after we release, so our heads don't explode. :-)
  • API Security Api more security #1196

@kylejohnson

@SteveGilvarry

Anything not mentioned here means we do not plan to include it in the next release, so please comment if I am missing something.

Once these items are completed, I plan to immediately create a draft release for beta test. We've changed quite a bit this round, and I expect there to be issues we have not discovered yet.

@pliablepixels
Copy link
Member

API: Confirmed we are at a good stopping point for 1.29
Cool ideas: no more PRs till 1.29 is released.

@kylejohnson
Copy link
Member

I'd like to get #1120 into this release.

@SteveGilvarry
Copy link
Member

@knnniggett all the details are in the pull I did, if you want me to document it and add to the release wiki entry can do.
#966

github_changelog_generator -t [Insert Github Token] --no-issues --future-release 1.29.0 ZoneMinder/ZoneMinder
Looks like it is grabbing pull requests from other branches however, if I can work out how to edit a gem I would fix it.

@knight-of-ni
Copy link
Member Author

@SteveGilvarry no, that's good enough. I just couldn't remember where you mentioned it.

@pliablepixels
Copy link
Member

That plugin rocks. I discovered it yesterday and migrated to it as well.

@pliablepixels
Copy link
Member

I'd also request we add this #1136 to 1.29 - it will help me implement previous/next and gapless event navigation

@kylejohnson
Copy link
Member

We gotta do a code freeze at some point!

On 11/02/2015 03:06 PM, Pliable Pixels wrote:

I'd also request we add this #1136
#1136 to 1.29 - it will
help me implement previous/next and gapless event navigation


Reply to this email directly or view it on GitHub
#1115 (comment).

@onlyjob
Copy link
Contributor

onlyjob commented Nov 3, 2015

Maybe we could include ffmpeg-2.9 compatibility update #1137?

@knight-of-ni
Copy link
Member Author

I'm pasting this here so I can see what the markup looks like.

I used the following command to generate this list:
github_changelog_generator --since-tag v1.28.1 --token [my token] ZoneMinder/ZoneMinder

If you think one of the many additional options this tool supports would be helpful then please let me know.

[Trimmed out the example changelog, issue too long :-)]

@pliablepixels
Copy link
Member

One thing to note is that we need to correctly categorize bugs vs.
enhancement labels before we generate this. the current list has them
mixed due to how they were labelled.

@knight-of-ni
Copy link
Member Author

Just thought of something else.

As part of the release notes for 1.29, I would like to make an end of life announcement for the following:

  • Autotools (replaced by cmake)
  • mobile skin (use zmNinja instead)
  • XML skin (replaced by API)

I'd like ZoneMinder 1.29 to be the last version to support these items.

This is an invitation for discussion. Please let me know what you think.

@kylejohnson
Copy link
Member

@knnniggett - If that's the case, I say we remove the respective files from the repo, e.g. web/skins/(mobile|xml)

@knight-of-ni
Copy link
Member Author

Yes, exactly. Following the release of 1.29 and the end-of-life announcement, I'd like to remove all the files that make up the mentioned items. I do want to make sure we announce it sufficiently so we minimize the surprise factor.

As far as I know, those of us doing active development have all switched to cmake.

@SteveGilvarry
Copy link
Member

Any archs that don't support cmake?

On Wed, 11 Nov 2015 at 8:25 AM, Andrew Bauer [email protected]
wrote:

Yes, exactly. Following the release of 1.29 and the end-of-life
announcement, I'd like to remove all the files that make up the mentioned
items. I do want to make sure we announce it sufficiently so we minimize
the surprise factor.

As far as I know, those of us doing active development have switched to
cmake.


Reply to this email directly or view it on GitHub
#1115 (comment)
.

@pliablepixels
Copy link
Member

if I remember correctly, removing them will break zmView Pro though (not sure but I think it does rely on some of these skins)

@knight-of-ni
Copy link
Member Author

@SteveGilvarry Archs or Distros? cmake is available in every Linux distro that I am aware of and is also available for Mac OS X, freebsd, Solaris, and even Windows. Are there any other OS'es that come to mind?

@pliablepixels I think @kylejohnson would agree that the intent of the API is to replace current third party integration methods. We would expect the authors of any third party apps out there still using the XML skin to transition to using the API.

So the idea would be to make the end of life announcement, wait a reasonable amount of time for additional feedback, and then actually delete the items in question when we feel we have waited sufficiently.

@SteveGilvarry
Copy link
Member

@knnniggett that probably covers it, I was trying to think what we had seen people trying to run it on, be it OS and also architectures, but I suppose it is an OS thing and that is all the ones I have seen.

Also note I am having a look at the changelog generator to see if I can get it to only bring in pull requests on master.

@knight-of-ni
Copy link
Member Author

@connortechnology Can you speak to the current status of Freebsd development, particularly whether or not the build process has been migrated to cmake?

@connortechnology
Copy link
Member

I used cmake the last time I tried to compile on FreeBSD. It works fine.

@connortechnology
Copy link
Member

The FreeaBSD ports thing uses autoconf, but I'm sure they don't really care. Their build process has a lot of alternative infrastructure.

Honestly, I only care about it basically compiling on freebsd, not how easy it will be. Anyone building this on freebsd will have to know what they are doing.

@pliablepixels
Copy link
Member

@knnniggett - folks on the forum seem to be commenting that neither scilinux nor centOS7 supports the image scale API that #1000 requires - I'm not sure that's correct, but I'm hearing more of it, if you'd like to take a look at least on CentOS before merging. Thread in question: https://forums.zoneminder.com/viewtopic.php?f=32&t=23645&p=90523#p90523 --> both BiloxiGeek (SciLinux) and Abi (CentOS7) seem to be saying this

@knight-of-ni
Copy link
Member Author

All they have to do is make sure the php-gd package is installed.

Thanks,

Andy

No Trees were killed in the sending of this message.
However, a large number of electrons were terribly inconvenienced.

Date: Sun, 15 Nov 2015 09:25:24 -0800
From: [email protected]
To: [email protected]
CC: [email protected]
Subject: Re: [ZoneMinder] Release v1.29.0 (take two) (#1115)

@knnniggett - folks on the forum seem to be commenting that neither scilinux nor centOS7 supports the image scale API that #1000 requires - I'm not sure that's correct, but I'm hearing more of it, if you'd like to take a look at least on CentOS before merging. Thread in question: https://forums.zoneminder.com/viewtopic.php?f=32&t=23645&p=90523#p90523 --> both BiloxiGeek (SciLinux) and Abi (CentOS7) seem to be saying this


Reply to this email directly or view it on GitHub.

@pliablepixels
Copy link
Member

Doesn't seem to be the case @knnniggett - looks like imagescale() is only available in PHP 5.5 while CentOS 7 seems to have 5.4

@knight-of-ni
Copy link
Member Author

Then that is a problem. We will need to do something other than call imagescale when php < 5.5

Thanks,

Andy

No Trees were killed in the sending of this message.
However, a large number of electrons were terribly inconvenienced.

Date: Sun, 15 Nov 2015 11:53:53 -0800
From: [email protected]
To: [email protected]
CC: [email protected]
Subject: Re: [ZoneMinder] Release v1.29.0 (take two) (#1115)

Doesn't seem to be the case @knnniggett - looks like imagescale() is only available in PHP 5.5 while CentOS 7 seems to have 5.4


Reply to this email directly or view it on GitHub.

@knight-of-ni
Copy link
Member Author

A quick google suggested that the imagecopyresized function (part of php-gd) can be used instead of imagescale

http://php.net/manual/en/function.imagecopyresized.php

Suggested here at the bottom:
http://stackoverflow.com/questions/27813479/imagescale-function-in-php

Thanks,

Andy

No Trees were killed in the sending of this message.
However, a large number of electrons were terribly inconvenienced.

Date: Sun, 15 Nov 2015 11:53:53 -0800
From: [email protected]
To: [email protected]
CC: [email protected]
Subject: Re: [ZoneMinder] Release v1.29.0 (take two) (#1115)

Doesn't seem to be the case @knnniggett - looks like imagescale() is only available in PHP 5.5 while CentOS 7 seems to have 5.4


Reply to this email directly or view it on GitHub.

@SteveGilvarry
Copy link
Member

@knnniggett I would recommend --no-issues as a flag for change log, this removes the spam issues and results in the Pull requests only which are the actual changes. I just did a PR on the generator to include a filter for release branch as current system brings in all PR's including ones on video and other branches. github-changelog-generator/github-changelog-generator#305
Then I would run it like this to create the 1.29.0 changelog file.
github_changelog_generator -t <Token> --no-issues --future-release 1.29.0 --release-branch master ZoneMinder/ZoneMinder

@connortechnology
Copy link
Member

I would like to propose that we name or in some way commemorate @manupap1 with this release. He made some very significant contributions during his time here.

@knight-of-ni
Copy link
Member Author

Excellent idea. I second the motion.

@connortechnology
Copy link
Member

Do you want me to do a PR for not showing the server column on the console for the non-multi-server case? I kinda think I should.

@knight-of-ni
Copy link
Member Author

Yeah, that's probably a good idea.

@knight-of-ni
Copy link
Member Author

Now that 44f3b99 hides the server column when not using mutliserver, are we ready for RC2?

@connortechnology
Copy link
Member

I am.

Please be advised though that once 1.29 is out, I have a ton of stuff to merge for 1.29.1. And stuff for 1.30. It will be interesting to see how people react to the multi-server stuff.

@connortechnology
Copy link
Member

BTW thanks for doing the multi-server documentation. You guys probably did a better job of it than I would have anyways.

@knight-of-ni
Copy link
Member Author

Yeah, that's why I'm pushing hard to get 1.29.0 out the door. It is holding us up. @SteveGilvarry has a bunch of stuff too, including his video branch.

@knight-of-ni
Copy link
Member Author

@connortechnology
After building and testing from the latest 1.29.0 branch, I seem to re running into a new issue with Multi-server. I was able to duplicate, and solve on my own system the issue described in the forum about the zm processes running on the wrong machine.

However, once I got past that I noticed that all the camera links in the web console were all pointing towards the local host machine, rather than the name or ip of the server the camera was hosted on.
Can't help but wonder if commit cb7acb3 had anything to do with that.

UPDATE: Nope, reversing cb7acb3 did not make any difference

@connortechnology
Copy link
Member

You say all the web links? Only the actual live steam link should point to the recorder. Everything else should stay on whatever server you are hitting. I'm planning long term to make it so that a recording server doesn't even need Apache at all. Just a persistent zms r something like that.

@knight-of-ni
Copy link
Member Author

If I open my browser to zm server A, and I hover over the link to a open a monitor for a camera that is mapped to server B, the link contains server A's hostname, rather than server B. So naturally when I click the link to open the monitor, I don't get a stream because the link is pointing to the wrong server. The backend is working, because I see "Capturing at x.xx fps".

@kylejohnson
Copy link
Member

The monitor view should be hosted on server A, but the img element in that view should point to server B, no?

On January 30, 2016 4:15:43 PM MST, Andrew Bauer [email protected] wrote:

If I open my browser to zm server A, and I hover over the link to a
open a monitor for a camera that is mapped to server B, the link
contains server A's hostname, rather than server B. So naturally when I
click the link to open the monitor, I don't get a stream because the
link is pointing to the wrong server. The backend is working, because I
see "Capturing at x.xx fps".


Reply to this email directly or view it on GitHub:
#1115 (comment)

Sent from my Android device with K-9 Mail. Please excuse my brevity.

@knight-of-ni
Copy link
Member Author

Well, that's not how I remember it working the last time I tested multiserver. I guess I'll have to take another look.

@connortechnology
Copy link
Member

It has never worked that way. It stays on the same server as much as possible. Only live streaming data hits the recording server.

My servers are all pretty stressed, so i actually use a non-recording server to access the ui.

@knight-of-ni
Copy link
Member Author

Yeah, I think I need to start over and try again because none of camera streams display the live stream anymore. The backend works. Just not the frontend.

@pliablepixels
Copy link
Member

I'd like to propose inclusion of this PR: #1254 --> so zmNinja for android doesn't keep streaming data in the background once 1.29 hits mainstream

@connortechnology
Copy link
Member

Propose it all you want. It's already merged.

@pliablepixels
Copy link
Member

heh, so that's what I asked on IRC - I was given to understand merged doesn't necessarily mean included in 1.29. If it will be, thanks!

@knight-of-ni
Copy link
Member Author

Merged into the master branch does not necessarily mean merged into the release-1.29.0 branch.
This statement is true.

@knight-of-ni
Copy link
Member Author

Closing. We're done! woo hoo!

@SteveGilvarry
Copy link
Member

Good job on managing the release process, rc worked very well.
On Thu, 4 Feb 2016 at 1:47 PM, Andrew Bauer [email protected]
wrote:

Closing. We're done! woo hoo!


Reply to this email directly or view it on GitHub
#1115 (comment)
.

@pliablepixels
Copy link
Member

congratulations to the entire team!

@apbb2
Copy link

apbb2 commented Feb 5, 2016

Gentlemen,

First of all, thank you very much for all that you do for ZM. I have been using it since 1.24 with great success in multiple locations. It has become easier & easier to maintain & better every version.

I know this is probably forum questions but I have 2 questions that I wanted the development team to see.

  1. How can we contribute monetarily to ZM? I think it is time you guys gather some money together for your efforts & to keep ZM going for the foreseeable future. I for one would like to contribute.
  2. Isaac, when will your PPA be updated? Since you setup the PPA, it is the only way I will install ZM. It is simple & straight forward (except for the last hiccup) & could be the key to more users.

All in all a terrific job & you should all be congratulated.

Thank you.


Andrew Peykar

@connortechnology
Copy link
Member

You can send money directly to me. :)

Alternatively, go to bountysource https://www.bountysource.com/teams/zoneminder

The stable zoneminder PPA should already have packages for 1.29, I put them up yesterday.

Perhaps we should have a ZM bitcoin address... I'm happy to hold the wallet...

@knight-of-ni
Copy link
Member Author

I'm glad our policy of package based installation, over from-source builds, is having the intended effect on our end-users. I still shudder when I think about how the forums used to be years ago.... Most of the topics being posted were build problems, and those same problems would repeat with each upgrade of ZoneMinder or the underlying OS. That left little time to make progress on anything else.

Lately, we have been talking about the future of ZoneMinder. In order to get the project to make real progress, we need to grow it into something more than a free-time hobby, but of course that requires money. That in turn requires a source of revenue.

One thing we have discussed to help make that happen is to find a commercial entity out there who would be willing to be a showcase for the ZoneMinder product. Additionally, we are looking for customers interested in a support plan. @apbb2 If you are interested in either of these, then please contact us.

@apbb2
Copy link

apbb2 commented Feb 5, 2016

I am interested in both possibly showcasing & helping out monetarily (somewhat, I only have so much in my budget). Contact me off list so we can discuss if you like.

Isaac, any chance for an upgrade using 12.04 or is it not supported? That’s why I did not see the upgrade as all my current units are on 12.04

Thanks.


Andrew Peykar

@apbb2
Copy link

apbb2 commented Feb 5, 2016

Put $200 in BountySource. Thanks again for all your hard work guys.

@connortechnology
Copy link
Member

Thanks @apbb2 That's much appreciated.

@SteveGilvarry
Copy link
Member

@onlyjob FYI 1.29 is released, just in case you were not aware.
https://github.com/ZoneMinder/ZoneMinder/releases
Note don't use Source Code links in github due to missing submodules.
ZoneMinder-1.29.0.tar.gz link instead

@onlyjob
Copy link
Contributor

onlyjob commented Feb 7, 2016

Thanks, @SteveGilvarry. I'll be working on 1.29.0 soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants