Change ways to composite video clips by using PIL #1157
Conversation
|
Hello! Thank you for making this contribution, it looks like it will be quite useful. Let me know if you need a hand with anything. In order to pass the code format check, you need to run |
tburrows13
added
the
enhancement
|
All done. But notice never nesting the |
moviepy/video/VideoClip.py
Outdated
| return np.minimum(1, picture + self.blit_on(np.zeros(framesize), t)) | ||
| # ? I'm not so sure about the function of this code, need information | ||
| # if self.ismask and picture.max(): | ||
| # return np.minimum(1, picture + self.blit_on(np.zeros(framesize), t)) |
There was a problem hiding this comment.
Thanks for your view, I annotated it since I have no idea about these code, but it still pass all tests anyway. Seems ok to delete them.
|
Hey, I was just wondering if this code is still in the works. Has someone had the chance to look at the test_subtitles failure? Any ideas on when this code might get merged in, if at all? Thanks for all the efforts. |
|
@Garett-MacGowan I also noticed that the subtitle test failed. I tested it on my pc, but I don’t remember it a bit. If you have time, can you test it manually? |
|
I should have a little bit of time this week. I'll try and test it manually and come to a resolution. |
|
@Garett-MacGowan Just checking in here, did you eventually find time to test this? |
|
Linking #1145 and also a bug fix that may need to be applied here as well: https://www.reddit.com/r/moviepy/comments/i1z3rq/rendering_a_10_minute_video_takes_hours/g03gu6m/ This PR is on my todo list to get finalised and merged. |
|
Ah sorry, I messed this PR up whilst trying to fix the merge conflicts. It seems that I can't fix it without proper write permissions to |
This is mainly due to the performance issues on CompositeVideoClip, by changing dependency to PIL, it becomes 25 times faster.