Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move directory of test to temporal location and close clips #1407

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented Jan 11, 2021

  • I have formatted my code using black -t py36

  • Used temporal directory to save the directory temp_audiofile of the test test_VideoClip.py::test_write_videofiles_with_temp_audiofile_path to prevent that a directory temp_audiofile would be created in the root of the project.

  • Closed the video clip explicitly using utils.close_all_clips.

@coveralls
Copy link

coveralls commented Jan 11, 2021

Coverage Status

Coverage remained the same at 67.525% when pulling a0e5c48 on mondeja:improve-tests-1 into 6ab3efb on Zulko:master.

@tburrows13 tburrows13 added the tests Related to individual tests in the test suite or running the test suite. label Jan 11, 2021
@tburrows13 tburrows13 merged commit 9647679 into Zulko:master Jan 11, 2021
@mondeja mondeja deleted the improve-tests-1 branch January 11, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Related to individual tests in the test suite or running the test suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants