Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Fix/readme repo template #840

Merged
merged 18 commits into from
Feb 3, 2021
Merged

Fix/readme repo template #840

merged 18 commits into from
Feb 3, 2021

Conversation

GuillaumeFalourd
Copy link
Contributor

Description

The README template used for creating new formulas repositories needed an update due to broken link and deprecated sections.

How to verify it

Create a new repository using Ritchie rit create formula command.

Changelog

Fix README repo template.

@GuillaumeFalourd GuillaumeFalourd added 📚 documentation Improvements or additions to documentation deprecation Some function got removed labels Jan 28, 2021
@GuillaumeFalourd GuillaumeFalourd added this to the 2.9.0 milestone Jan 28, 2021
@GuillaumeFalourd GuillaumeFalourd self-assigned this Jan 28, 2021
Copy link
Contributor

@kaduartur kaduartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have edited a README.md for integration tests only. I think you need to edit this README.md

@GuillaumeFalourd
Copy link
Contributor Author

Great point Kadu, I'll update this one as well 👍🏼

@GuillaumeFalourd
Copy link
Contributor Author

Done: ZupIT/ritchie-formulas#336

@brunasilvazup
Copy link
Contributor

in QA it's fine.

Copy link
Contributor

@kaduartur kaduartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@brunasilvazup brunasilvazup merged commit 9db5cd2 into ZupIT:master Feb 3, 2021
@brunasilvazup brunasilvazup removed the 📚 documentation Improvements or additions to documentation label Feb 10, 2021
@GuillaumeFalourd GuillaumeFalourd deleted the fix/readme-repo-template branch May 6, 2021 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
deprecation Some function got removed ✔️ ready-for-review ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants