This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 102
Fix/readme repo template #840
Merged
brunasilvazup
merged 18 commits into
ZupIT:master
from
GuillaumeFalourd:fix/readme-repo-template
Feb 3, 2021
Merged
Fix/readme repo template #840
brunasilvazup
merged 18 commits into
ZupIT:master
from
GuillaumeFalourd:fix/readme-repo-template
Feb 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GuillaumeFalourd <[email protected]>
…d/ritchie-cli into bug/stdin-docker
Signed-off-by: GuillaumeFalourd <[email protected]>
GuillaumeFalourd
added
📚 documentation
Improvements or additions to documentation
deprecation
Some function got removed
labels
Jan 28, 2021
GuillaumeFalourd
requested review from
brunasilvazup,
henriquemoraeszup,
kaduartur,
lucasdittrichzup and
rodrigomedeirosf
as code owners
January 28, 2021 19:22
brunasilvazup
approved these changes
Jan 28, 2021
kaduartur
approved these changes
Feb 1, 2021
kaduartur
suggested changes
Feb 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have edited a README.md for integration tests only. I think you need to edit this README.md
Great point Kadu, I'll update this one as well 👍🏼 |
in QA it's fine. |
kaduartur
approved these changes
Feb 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
brunasilvazup
removed
the
📚 documentation
Improvements or additions to documentation
label
Feb 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The README template used for creating new formulas repositories needed an update due to broken link and deprecated sections.
How to verify it
Create a new repository using Ritchie
rit create formula
command.Changelog
Fix README repo template.