-
Notifications
You must be signed in to change notification settings - Fork 102
Adding feature containsAny, containsAll, containsOnly, notContainsAny and notContainsAll in conditional options #874
Adding feature containsAny, containsAll, containsOnly, notContainsAny and notContainsAll in conditional options #874
Conversation
… on conditional options Signed-off-by: Finzi <[email protected]>
Signed-off-by: Finzi <[email protected]>
Signed-off-by: Finzi <[email protected]>
Signed-off-by: Finzi <[email protected]>
Signed-off-by: Finzi <[email protected]>
Signed-off-by: Finzi <[email protected]>
Signed-off-by: Finzi <[email protected]>
Signed-off-by: Finzi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #874 +/- ##
==========================================
+ Coverage 84.45% 84.46% +0.01%
==========================================
Files 113 113
Lines 4034 4037 +3
==========================================
+ Hits 3407 3410 +3
Misses 433 433
Partials 194 194
Continue to review full report at Codecov.
|
Signed-off-by: Finzi <[email protected]>
Signed-off-by: Finzi <[email protected]>
Signed-off-by: Finzi <[email protected]>
Signed-off-by: Finzi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, just a comment, but looks good 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some suggestions, but it's up to you.
Independent, great functionality, congratulations 👏 (:
/merge qa |
👌 Merged branch feature/adding-contains-conditional into qa |
Signed-off-by: Finzi <[email protected]>
ddc1da3
Signed-off-by: Finzi <[email protected]>
/merge qa |
👌 Merged branch feature/adding-contains-conditional into qa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Signed-off-by: Finzi [email protected]
Issue: #858
Description
Adding feature containsAny, containsAll, containsOnly, notContainsAny and notContainsAll in conditional options
How to verify it
Create a formula with the new conditional options.
Example of a config.json with containsAny:
Changelog
Adding feature containsAny, containsAll, containsOnly, notContainsAny and notContainsAll in conditional options