chore: Update toolchain to nightly-2024-09-30 #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns the toolchain with Binius: https://gitlab.com/IrreducibleOSS/binius/-/blob/main/rust-toolchain.toml?ref_type=heads By updating the toolchain, we solve the following error: ``` cargo run --release Compiling ark-bn254 v0.4.0 Compiling binius_field v0.1.0 (https://gitlab.com/UlvetannaOSS/binius#33eab8c9) error[E0658]: use of unstable library feature 'iter_repeat_n' --> /Users/user/.cargo/git/checkouts/binius-073c6a8ffd019076/33eab8c/crates/field/src/packed.rs:225:76 | 225 | self.iter().skip(block_idx * block_len).take(block_len).flat_map(|elem| iter::repeat_n(elem, repeat)) | ^^^^^^^^^^^^^^ | = note: see issue #104434 <rust-lang/rust#104434> for more information = help: add `#![feature(iter_repeat_n)]` to the crate attributes to enable = note: this compiler was built on 2024-07-31; consider upgrading it if it is out of date For more information about this error, try `rustc --explain E0658`. error: could not compile `binius_field` (lib) due to 1 previous error ``` It solves an issue with the nightly compiler version and the use of `iter::repeat_n` that was introduced three days ago: https://gitlab.com/IrreducibleOSS/binius/-/commit/0c8c49b5cf7145949d5cbd4a237cda736c0dd1d3
WillPapper
added a commit
to WillPapper/a16z-rust
that referenced
this pull request
Nov 22, 2024
This matches the toolchain used by Jolt in this PR: a16z/jolt#510 The compiler is updated to align with features used by Binius (in particular the use of `iter::repeat_n`)
|
Added the corresponding PR to |
moodlezoup
pushed a commit
to a16z/rust
that referenced
this pull request
Nov 22, 2024
This matches the toolchain used by Jolt in this PR: a16z/jolt#510 The compiler is updated to align with features used by Binius (in particular the use of `iter::repeat_n`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns the toolchain with Binius's rust-toolchain
By updating the toolchain, we solve the following error on the starter project:
The toolchain update solves an incompatibility between the nightly compiler version in use by Jolt and the use of
iter::repeat_nthat was introduced three days ago in Binius.This fixes #508. I will open a separate PR in a16z/rust for the CI pipeline