Render WebmentionJSTag with a dedicated class #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmaroli
force-pushed
the
js-tag-renderer
branch
4 times, most recently
from
e183827
to
f406010
Compare
lib/jekyll/webmention_io.rb
Outdated
| end | ||
| end | ||
|
|
||
| def self.gathered_templates |
There was a problem hiding this comment.
What do you think about renaming this html_templates?
There was a problem hiding this comment.
I think html_templates will do fine 😃
|
I like this approach. Thank you! I added two questions/comments. PS - I had not seen the ||= assignment pattern before. Using that with return is pretty clever! |
🙂 You're welcome. |
|
This had a noticeable speed improvement. Thank you for making it happen! |
There was none at my end though.. (probably coz I'm on Windows....) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #99
The rendered output of
WebmentionJSTagis the same irrespective of givencontext. So the content can be rendered once, cached elsewhere and then retrieved from the cache for each call to the tag's:rendermethod.(This PR also involves a micro-optimization by caching array of supported_templates in the main module itself, to avoid unnecessary allocations)