Refactor integration tests #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronmondal
force-pushed
the
refactor-integration-tests
branch
10 times, most recently
from
827436b to
f79a26f
Compare
Remove the broken docker-compose workflows, rewrite the tests to be rootlessly runnable via bazel and pin infrastructure outside of Bazel's build graph in Nix. Each integration test now spins up a nativelink deployment in K8s, runs the test and removes the deployment again. All integration tests now have timeouts to provide faster feedback on failing tests. Apart from a few dynamically declared IPs the new approach is fully reproducible and can reuse containers from the existing nix workflow. The "build nativelink with nativelink" test has been removed as the LRE/Remote test already covers that usecase.
aaronmondal
force-pushed
the
refactor-integration-tests
branch
from
f79a26f to
56ab650
Compare
aaronmondal
force-pushed
the
main
branch
2 times, most recently
from
376a87f to
758c5d7
Compare
aaronmondal
force-pushed
the
main
branch
3 times, most recently
from
4899d2f to
8ff33bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also
include relevant motivation and context.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
not work as expected)
How Has This Been Tested?
Please also list any relevant details for your test configuration
Checklist
bazel test //...passes locallygit amendsee some docs