Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to asfv1 parser #1

Merged
merged 18 commits into from
Aug 11, 2024
Merged

Switch to asfv1 parser #1

merged 18 commits into from
Aug 11, 2024

Conversation

aazuspan
Copy link
Owner

Major refactor to switch from a custom Lark parser to a parser based on asfv1. No point reinventing the wheel, since it's already a feature-complete parser for SPINAsm. We do need to hack some functionality onto the parser, including:

  1. Track current column of the parser
  2. Record when symbols are defined
  3. Offset lines to zero-indexed
  4. Record errors and warnings as LSP diagnostics
  5. Prevent early exits when errors are encountered.

Those changes are all handled by the SPINAsmParser subclass of fv1parse.

This also includes a lot of incidental refactoring, additional documentation, more LSP features, LSP tests, etc.

@aazuspan aazuspan added the enhancement New feature or request label Aug 11, 2024
@aazuspan aazuspan self-assigned this Aug 11, 2024
@aazuspan aazuspan merged commit f13b952 into main Aug 11, 2024
5 checks passed
@aazuspan aazuspan deleted the asfv1 branch August 11, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant