Regression testing #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generating the encoding once should speed up semantic token requests since they can be cached with the parser, and it will also make it easier to regression test. Parsing on init prevents having an "unparsed" parser, which would complicate accessing things like evaluated tokens and semantic encoding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28 by adding regression testing for the parser's output state with the example patches, via
pytest-regressions.Currently, I test:
evaluated_tokenssemantic_encodingdiagnosticsThis excludes the intermediate and internal attributes like
_parsed_tokensorsymtbl, since those should all be reflected in theevaluated_tokens.This does not exhaustively test the tokens, since their properties (like hover data) aren't evaluated. That should all be well-covered by existing tests, but might be worth adding in the future.