Inconsistent diagnostics #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diagnostic positions were reported inconsistently based on newlines after the error line. This was caused by updating the parser's previous character every time the parser moved to a new line, rather than leaving the previous character on the last parsed token. Because asfv1 doesn't raise errors until it hits a non-whitespace token, this meant that the previous character would be moved from the token that caused the error to the whitespace that followed it. Now, the previous character is only updated once at the beginning of __next__, meaning that it stays on the last successfully parsed token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27
Diagnostic positions were reported inconsistently based on newlines
after the error line. This was caused by updating the parser's
previous character every time the parser moved to a new line, rather
than leaving the previous character on the last parsed token. Because
asfv1 doesn't raise errors until it hits a non-whitespace token,
this meant that the previous character would be moved from the token
that caused the error to the whitespace that followed it.
Now, the previous character is only updated once at the beginning of
__next__, meaning that it stays on the last successfully parsed token.We could use more diagnostic tests overall, but this covers the reported bug.