-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Role connections & subscriptions #1487
Merged
bsian03
merged 22 commits into
abalabahaha:dev
from
conorwastakenwastaken:roleconnections
Jul 9, 2024
Merged
feat: Role connections & subscriptions #1487
bsian03
merged 22 commits into
abalabahaha:dev
from
conorwastakenwastaken:roleconnections
Jul 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorwastakenwastaken
changed the title
feat: Role connections
feat: Role connections & subscriptions
Feb 10, 2024
bsian03
requested changes
Apr 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is everything related to role connections
bsian03
requested changes
Apr 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
role subscriptions
Co-authored-by: bsian03 <[email protected]>
bsian03
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds role connections to Eris.
Hopefully I haven't missed anything. I've checked both the docs and the above PR in the API GH repo (that Bsian kindly linked for me) but honestly the pr diff was a mess and hard to read so I could've missed something.
Also adds role subscriptions to Eris.
I need to add the message content for the role subscription message that Discord sends, but I've no idea wtf the content is so any help would be appreciated!Additions:
editRoleConnectionMetadataRecords()
func in ClientgetRoleConnectionMetadataRecords()
func in ClientMessage#roleSubscriptionData
propertyrole_connections_verification_url
property underOAuthApplicationInfo