Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend slim based image than alpine based image #9

Closed
rscarrera27 opened this issue Nov 7, 2019 · 1 comment · Fixed by #11
Closed

Recommend slim based image than alpine based image #9

rscarrera27 opened this issue Nov 7, 2019 · 1 comment · Fixed by #11
Labels

Comments

@rscarrera27
Copy link

alpine based image does not contains requirements for c-extension. so many libs use c-extensions can not installed.
I recommend slim or slim-buster for base image

ref: https://pythonspeed.com/articles/base-image-python-docker-images/

abatilo added a commit that referenced this issue Nov 19, 2019
This change introduces variables for allowing you to set whatever
versions of Python and poetry you'd like to install. You set these using
the GitHub Actions `with` block, where you can set `python_version` and
`poetry_version`. There are defaults listed in the action.yml. We are
considering letting those defaults automatically go lookup the latest
versions of python and/or poetry. This is as opposed to the previous
behavior which would only run the latest version of Python, and the
latest version of poetry.

At the same time, we've switched off using Alpine as this has been a
popular request.

Fixes #8
Fixes #9
Fixes #10
abatilo added a commit that referenced this issue Nov 19, 2019
This change introduces variables for allowing you to set whatever
versions of Python and poetry you'd like to install. You set these using
the GitHub Actions `with` block, where you can set `python_version` and
`poetry_version`. There are defaults listed in the action.yml. We are
considering letting those defaults automatically go lookup the latest
versions of python and/or poetry. This is as opposed to the previous
behavior which would only run the latest version of Python, and the
latest version of poetry.

At the same time, we've switched off using Alpine as this has been a
popular request.

Fixes #8
Fixes #9
Fixes #10
abatilo added a commit that referenced this issue Nov 19, 2019
* feat: support setting of python and poetry versions

This change introduces variables for allowing you to set whatever
versions of Python and poetry you'd like to install. You set these using
the GitHub Actions `with` block, where you can set `python_version` and
`poetry_version`. There are defaults listed in the action.yml. We are
considering letting those defaults automatically go lookup the latest
versions of python and/or poetry. This is as opposed to the previous
behavior which would only run the latest version of Python, and the
latest version of poetry.

At the same time, we've switched off using Alpine as this has been a
popular request.

Fixes #8
Fixes #9
Fixes #10

* update ci to pass in versions

* run matrix for testing multiple versions
@github-actions
Copy link

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant