-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IsReleaseBuild() returns incorrect info. #438
Comments
I took a look at our v0.5.0 and go install ./... and Line 66 in 23068d1
devel and it is expected. See golang/go#29228. I think probably we need to change our mechanism to hide some api versions.
I checked the v0.5.0 via |
For v0.5.0, the version is different either |
TL;DR
Ideally,
IsReleaseBuild
returns true if this binary was built by goreleaser as part of// the official release process (as opposed to a user just running "go build",
// or running in a CI environment, or something else). But somehow when I install abc cli via
go install ./...
, orabc/cmd/abc/abc_test.go
Line 66 in 23068d1
IsReleaseBuild
also returns trueExpected behavior
No response
Observed behavior
No response
Environment Details
Additional information
No response
The text was updated successfully, but these errors were encountered: