Skip to content

Commit

Permalink
Change name of server certs in integration tests (ansible-collections…
Browse files Browse the repository at this point in the history
…#1503)

Change name of server certs in integration tests

SUMMARY

There is a mismatch in the terminator repo for the permissions on iam server certs and the terminator class for server certs. This has led to the CI account reaching the quota for server certs, as some of the older certs are not getting cleaned up.
I don't know the reasoning behind limiting the terminator class to only certs prefixed with ansible-test. The safest option here seems to be to change the permissions to only allow creating certs with this prefix. Once this update is merged I'll change the permissions on the terminator repo and manually clear out the older certs.

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
  • Loading branch information
gravesm authored Sep 20, 2022
1 parent 9748d1d commit 3847690
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@

- name: create certificate
iam_server_certificate:
name: 'nlb_{{ tiny_prefix }}'
name: 'ansible-test-nlb-{{ tiny_prefix }}'
state: present
cert: "{{ lookup('file', path_cert_pem) }}"
key: "{{ lookup('file', path_cert_key) }}"
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/targets/elb_network_lb/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@

- name: destroy certificate
iam_server_certificate:
name: 'nlb_{{ tiny_prefix }}'
name: 'ansible-test-nlb-{{ tiny_prefix }}'
state: absent
register: remove_cert
ignore_errors: yes
Expand Down

0 comments on commit 3847690

Please sign in to comment.