Skip to content

Commit

Permalink
Merge pull request ansible-collections#592 from msven/sqsQueueIdempotent
Browse files Browse the repository at this point in the history
Fix queue attribute comparison

SUMMARY

Fixes sqs queue attribute comparison so updates are not performed on subsequent runs.  Also adds integration tests to verify this behavior.

Fixes ansible-collections#578
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

sqs_queue
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell <None>
  • Loading branch information
ansible-zuul[bot] authored Jul 9, 2021
2 parents 625695f + c4614e5 commit eea7739
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sqs_queue.py
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ def update_sqs_queue(module, client, queue_url):
new_value = str(new_value).lower()
value = str(value).lower()

if new_value == value:
if str(new_value) == str(value):
continue

# Boto3 expects strings
Expand Down

0 comments on commit eea7739

Please sign in to comment.