Restore setting of channel modes for presence feature #133
Labels
enhancement
New feature or improved functionality.
Comments
lawrence-forooghian
added a commit
that referenced
this issue
Nov 20, 2024
This code is not actually doing anything at the moment; the way in which we’re currently fetching channels means that these modes get overwritten, which we’ll fix in #132. But, when we fix the aforementioned, we’ll see that setting these flags leads to some weird Realtime behaviours, so we’ll turn them off for now and restore them separately in #133.
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Until #132, the channel modes used by the presence feature as described by CHA-RL9a and CHA-RL9b were not actually being used (same issue existed in JS, too). Once I restored these flags, message subscriptions became broken as described in ably/specification#233 (comment) (
channelSerialabsent fromATTACHEDprotocol message). Whilst waiting for this Realtime issue to be investigated, and for the aforementioned spec points to be clarified in ably/specification#236, I’ve commented out the code for setting these flags. Restore it when possible.I don't think this needs to be a blocker for beta since the same issue has existed in JS for a while.
Internal Slack discussion on Realtime behaviour
┆Issue is synchronized with this Jira Story by Unito
The text was updated successfully, but these errors were encountered: