Fix validation of referenced field for foreign key constraint (#77)

CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 
 *The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)*
 
+## 0.3.1 - UNRELEASED
+
+### Fixed
+
+- Fix validation of referenced field for foreign key constraint.
+
 ## 0.3.0 - 2024-01-12
 
 ### Added

src/automigrate/models.clj

@@ -109,15 +109,17 @@
   Also check that field should have `:unique` option enabled, and
   it has the same type as origin field."
   [qualified-field-name field-options fk-field-options fk-model-name fk-field-name]
-  (when-not (true? (:unique fk-field-options))
+  (when-not (or (true? (:unique fk-field-options))
+              (true? (:primary-key fk-field-options)))
     (let [qualified-fk-field-name (keyword (name fk-model-name) (name fk-field-name))]
       (throw+ {:type ::referenced-field-is-not-unique
                :title "MODEL ERROR"
                :data {:referenced-model fk-model-name
                       :referenced-field fk-field-name}
-               :message (format "Foreign key %s has reference on the not unique field %s."
+               :message (format "Foreign key %s there is no unique or primary key constraint on the referenced field %s."
                           qualified-field-name
                           qualified-fk-field-name)})))
+
   (let [field-type-group (fields/check-type-group (:type field-options))
         fk-field-type-group (fields/check-type-group (:type fk-field-options))
         qualified-fk-field-name (keyword (name fk-model-name) (name fk-field-name))]

test/automigrate/models_errors_test.clj

@@ -580,7 +580,8 @@
   (testing "check referenced field is not unique error"
     (let [data {:bar [[:id :integer]]
                 :foo {:fields [[:bar-id :integer {:foreign-key :bar/id}]]}}]
-      (is (= "Foreign key :foo/bar-id has reference on the not unique field :bar/id."
+      (is (= (str "Foreign key :foo/bar-id there is no unique or primary key constraint"
+               " on the referenced field :bar/id.")
             (:message (test-util/thrown-with-slingshot-data?
                         [:type ::models/referenced-field-is-not-unique]
                         (models/->internal-models data))))))))

test/automigrate/models_test.clj

@@ -59,7 +59,7 @@
                 :account
                 {:fields {:id {:type :serial}}}}]
     (is (thrown-with-msg? ExceptionInfo
-          #"Foreign key :feed/account has reference on the not unique field :account/id."
+          #"Foreign key :feed/account there is no unique or primary key constraint on the referenced field :account/id."
           (#'models/validate-foreign-key models)))))