Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup.py: adjust two dependencies to allow installation via pip #1485

Merged
merged 2 commits into from
Apr 2, 2019
Merged

setup.py: adjust two dependencies to allow installation via pip #1485

merged 2 commits into from
Apr 2, 2019

Conversation

dankegel
Copy link
Contributor

This should fix #1463 and #1484.

dankegel added 2 commits March 30, 2019 12:37
@dankegel
setup.py: pin more_itertools to support python 2.7; fixes aboutcode-o…
c0cf1eb 
…rg#1463

Signed-off-by: Dan Kegel <[email protected]>
@dankegel
setup.py: loosen dependency on future; fixes aboutcode-org#1484
55aca1a 
Otherwise 'scancode --help' aborts if future was already installed.

Signed-off-by: Dan Kegel <[email protected]>
@codecov
Copy link

codecov bot commented Mar 30, 2019

Codecov Report

Merging #1485 into develop will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1485      +/-   ##
===========================================
+ Coverage    84.29%   84.34%   +0.04%     
===========================================
  Files          121      121              
  Lines        14143    14143              
===========================================
+ Hits         11922    11929       +7     
+ Misses        2221     2214       -7
Impacted Files Coverage Δ
src/typecode/pygments_lexers.py 52.9% <0%> (+0.64%) ⬆️
src/commoncode/fileutils.py 82.5% <0%> (+1.32%) ⬆️
src/scancode/api.py 94.81% <0%> (+1.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3f9b01...55aca1a. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 30, 2019 •
edited
Loading

Codecov Report

Merging #1485 into develop will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1485      +/-   ##
===========================================
+ Coverage    84.29%   84.34%   +0.04%     
===========================================
  Files          121      121              
  Lines        14143    14143              
===========================================
+ Hits         11922    11929       +7     
+ Misses        2221     2214       -7
Impacted Files Coverage Δ
src/typecode/pygments_lexers.py 52.9% <0%> (+0.64%) ⬆️
src/commoncode/fileutils.py 82.5% <0%> (+1.32%) ⬆️
src/scancode/api.py 94.81% <0%> (+1.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3f9b01...55aca1a. Read the comment docs.

pombredanne
pombredanne approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ++ ... merging!

@pombredanne pombredanne merged commit 8e01393 into aboutcode-org:develop Apr 2, 2019
@pombredanne pombredanne mentioned this pull request Apr 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pip install fails on fresh ubuntu 16.04 instance
2 participants
@dankegel @pombredanne