Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle NoneType in VersionRange.from_string #115

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Conversation

keshav-space
Copy link
Member

@keshav-space keshav-space requested a review from TG1999 August 29, 2023 21:11
src/univers/version_range.py Outdated Show resolved Hide resolved
Signed-off-by: Keshav Priyadarshi <[email protected]>
@keshav-space keshav-space requested a review from TG1999 August 30, 2023 08:20
@TG1999
Copy link
Contributor

TG1999 commented Aug 30, 2023

@keshav-space thanks, I think we should update the CI with the skeleton, some of these configurations are not supported any more.

Copy link
Contributor

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks++

@TG1999 TG1999 merged commit 0113d67 into main Aug 31, 2023
11 checks passed
@keshav-space keshav-space deleted the 113-fix-versionrange branch August 31, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throw ValueError when instantiating a VersionRange from None type
2 participants