-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature implement linked commits #1226
Feature implement linked commits #1226
Conversation
Thanks! |
That's something that was in the plan. Eventually an improver should be able to do anything it likes to do and the initial limitation with some "advisory" needed to be replaced. |
Signed-off-by: JafarAkhondali <[email protected]>
5dcb00d
to
9c564db
Compare
I've signed the commits, so DCO should be happy now :) |
+ Refactor Improver model to support custom improver + Update Improver documentation Signed-off-by: JafarAkhondali <[email protected]> Signed-off-by: JafarAkhondali <[email protected]> Signed-off-by: JafarAkhondali <[email protected]> Signed-off-by: JafarAkhondali <[email protected]>
5f442f0
to
cd115b3
Compare
@pombredanne There were some issues with formats, I fixed them and rebased the commits. |
@JafarAkhondali please rebase the PR |
@JafarAkhondali I am closing this for now as this is not finished/tested and cannot be merged yet. We are tracking the main "reachability" feature in: |
Please feel free to resubmit at a later stage. |
Hello, first-time contribution here.
I had to adjust
Improver
model to support custom improver, as the previous method assumes improvers will return always an advisory data (If I understood correctly).It's also safe to run the command multiple time, as it uses a one-to-one relation with constrain checking.
The
chain_urls
field might be filled in next PR to record usage of multiple links to reach commit(s).