Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest pub data through Github api #1417

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shravankshenoy
Copy link
Contributor

Fixes #1039

Changes Made

Modified github.py importer to ingest pub data and added test files

Other Considerations

The Github Advisory Database has very few advisories for Pub (https://github.com/advisories?query=type%3Areviewed+ecosystem%3Apub), hence one can see all of those in the pub_expected.json test file (just helps in case anyone wants to do an additional round of manual check with the source database)

@TG1999
Copy link
Contributor

TG1999 commented Feb 26, 2024

@shravankshenoy we need univers support for pub, see https://github.com/nexB/univers

@shravankshenoy
Copy link
Contributor Author

shravankshenoy commented Feb 27, 2024

@shravankshenoy we need univers support for pub, see https://github.com/nexB/univers

Thanks @TG1999 for sharing this. I went through the official pubspec documents (https://dart.dev/tools/pub/pubspec) to understand how versioning works in Dart, and I believe Dart follows semantic versioning (ref https://dart.dev/tools/pub/pubspec#version). However, I would like to learn a bit of Dart so that I can understand the docs better. Post that, I will try to create a PR in univers which supports pub. Until then I will convert this PR to a draft.

Moreover, since Rust/Cargo is supported in both purl spec and univers, I will create a similar PR for Rust which fixes #1039 . Hope that works

@TG1999
Copy link
Contributor

TG1999 commented Feb 27, 2024

@shravankshenoy 🙇 , IMO you don't need to learn dart for adding pub support in univers.

@shravankshenoy shravankshenoy marked this pull request as draft February 27, 2024 15:24
@shravankshenoy
Copy link
Contributor Author

@shravankshenoy 🙇 , IMO you don't need to learn dart for adding pub support in univers.

Got it 😅 Will try to create the PR to support pub on univers then.

@TG1999
Copy link
Contributor

TG1999 commented Jul 22, 2024

@shravankshenoy please rebase this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingest github ecosystems
3 participants